Allow to install Klippain in a given directory

[arcadien]

Allow to install Klippain for a given Kiauh installed printer.

[Frix-x]

Thanks for this PR!

This is something that was indeed needed and that I planned to work on at some point so thank you very much!

My only concern is about the cloned klippain repository: if you update one printer, all the Klippain printers of the host will be updated as well. But I think it's a good starting point already and not necessarly a problem if it's stated in the documentation.

As a side note, the Shake&Tune package will also need to be updated to be able to follow this change. Do you want to do a PR here as well?

[Frix-x]

Is it possible to add the printer name in the backup name?

[arcadien]

Hello, I tried to pack all changes at the same place. BACKUP_DIR is updated (printer name is append) at line 59.
I may propagate to Shake&Tune once I do it for my CR-10.

[arcadien]

I discover an issue with the patch. printer_data is also hardcoded in shell_commands.cfg. I had to manually update.
The file is a symlink from Klippain installation directory, and hence is shared across all printer configuration.

[Frix-x]

BACKUP_DIR is updated (printer name is append) at line 59

Oops, my bad, I did not see that. But can you change the "_" to a "/" to keep all the backups in the same folder and avoid very long folder names?

I discover an issue with the patch. printer_data is also hardcoded in shell_commands.cfg. I had to manually update.
The file is a symlink from Klippain installation directory, and hence is shared across all printer configuration.

Mhmm, you are indeed right. But I don't think there's any solution for this other than stating in the documentation that an override is needed... But since "multi-klipper" is not an officially supported way to install Klipper, this case should be very marginal and I think it's ok until we find a better way (maybe with the new Klipper plugin system that will probably come later this year).

[arcadien]

Ok done

[tsk-2222]

I did a kiauh multi install of 10 printers early last year. At the time, the installed directories were named printer_1_data to printer_10_data. It also created klipper-1.service to klipper-10.service.

When I try to run arcadien's install script with this command: './install.sh 8', the script fails because the '8_data' directory does not exist.

When I try to run the install script with this command: './install.sh printer_8', the script fails because it is looking for klipper-printer_8.service which doesn't exist.

Are you guys seeing this or do I have a 'funny' installation?

[arcadien]

@tsk-2222 i'll double check that later. AFAIR in my install, Kiauh created /home/pi/xx_data and klipper-xx.service for each xx named printer. It looks you have an extra printer- prefix to data folder which i have not.
I'll keep PR posted.

[tsk-2222]

@arcadien I can't test the kiauh scripts now but it looks like my situation happens when you tell kiauh how many printer instances to setup and DO NOT assign custom names. In this case, # by KIAUH convention, all instance names of only numbers need to be prefixed with 'printer_'

You can see this in the kiauh utilities.sh at line 700.
if [[ ${name} =~ ^[0-9]+$ ]]; then cfg_dirs+=("${HOME}/printer_${name}_data/config") else cfg_dirs+=("${HOME}/${name}_data/config")

[arcadien]

Ok so in that case, there will be printer_xx_data folder, but klipper-xx.service

[arcadien]

@tsk-2222 it should be fixed by last commit

[tsk-2222]

@arcadien
I'm not a bash pro by any means, but...
If I'm not mistaken, there's still a problem. If the printer is called 'printer_8' then the directory check will succeed, but then the next check at line 56 will always fail.

I think that maybe the script should consider the full name of the printer to be 'printer_8' for example and not just '8'. Then it could be handled in a similar way as if it was manually named it something like voron_8. Then during the check for the klipper service, just strip out any name beginning with 'printer_' and search for the klipper.8 service that kiauh created.

I hope that makes sense.

[Frix-x]

What is the state of this PR. Is it ok now? @tsk-2222 can you confirm it's ok for you now?
Unfortunately, I can only test it on a "single printer" host on my side.

[tsk-2222]

It's still broken on my end. Something like the following snippet seems to work for the Klippain install. It just strips off any leading "printer_" characters from SERVICE_NAME and allow the script to be called as such: "./install.sh printer_8"

if [ "$FORCE_PRINTER_NAME" != "" ]; then
      if [ -d "${HOME}/${FORCE_PRINTER_NAME}_data" ]; then
        echo "[PRE-CHECK] Installing Klippain for printer '${FORCE_PRINTER_NAME}'"
        PRINTER_NAME=$FORCE_PRINTER_NAME
#        if [[ ${PRINTER_NAME} =~ ^[0-9]+$ ]]; then
#          TARGET_DIR=${HOME}/printer_${PRINTER_NAME}_data
#        else
          TARGET_DIR=${HOME}/${PRINTER_NAME}_data
#        fi
        USER_CONFIG_PATH="${TARGET_DIR}/config"
        SERVICE_NAME=klipper-${PRINTER_NAME#printer_}   #strip off printer_ prefix to match kiauh service naming

The call to the shaketune install script will of course still fail until that gets updated also.

[tsk-2222]

I made some changes to install.sh and I believe it should work but I would like some more eyeballs.

tsk-2222@dfd8e61