Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit to Pest Converter #18

Merged
merged 11 commits into from
Feb 27, 2025
Merged

PHPUnit to Pest Converter #18

merged 11 commits into from
Feb 27, 2025

Conversation

FrittenKeeZ
Copy link
Owner

This pull request contains changes for migrating your test suite from PHPUnit to Pest automated by the Pest Converter.

Before merging, you need to:

  • Checkout the shift-141836 branch
  • Review all of the comments below for additional changes
  • Run composer update to install Pest with your dependencies
  • Run vendor/bin/pest to verify the conversion

@FrittenKeeZ
Copy link
Owner Author

ℹ️ Shift found external data providers in your PHPUnit test suite. These were converted to shared datasets in Pest. The original data providers were left in case they are used by other classes. If not, you may remove them once you complete your conversion to Pest.

@FrittenKeeZ
Copy link
Owner Author

FrittenKeeZ commented Feb 27, 2025

⚠️ Shift detected helper methods in the following PHPUnit tests. Currently Pest does not support namespaces. As such, these functions may result in a naming conflict.

While Shift converted these methods to functions in the new Pest test, you should review these files to see if these functions may be inlined or extracted to a custom helper.

  • ./tests/ConfigTest.php
  • ./tests/VouchersTest.php

@FrittenKeeZ
Copy link
Owner Author

ℹ️ Shift converted common PHPUnit assertions to Pest expectations. However, there may also be opportunities to chain your expectations together.

For example:

// Before
expect($comment)->toBeArray();
expect($comment)->toHaveCount(3);
expect($comment)->toContain('foo');

// After
expect($comment)->toBeArray()->toHaveCount(3)->toContain('foo');

@FrittenKeeZ
Copy link
Owner Author

FrittenKeeZ commented Feb 27, 2025

⚠️ Shift detected references to the PHPUnit test runner (vendor/bin/phpunit) in the following files. You should review these instances to see if they may be updated to the Pest test runner (vendor/bin/pest).

  • .github/workflows/workflow.yml

@FrittenKeeZ
Copy link
Owner Author

ℹ️ By default, Pest executes your tests sequentially within a single process. However, you may significantly decrease the time needed to run your tests by utilizing the --parallel option. You may review the documentation on parallel testing for additional details.

@FrittenKeeZ FrittenKeeZ merged commit 0d18205 into master Feb 27, 2025
15 checks passed
@FrittenKeeZ FrittenKeeZ deleted the shift-141836 branch February 27, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants