Re-add templating engine #676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8f41fe. This is needed since Mautic 4 still uses the Template Engine.
8 tasks
|
Ping? Can we get some help? This is blocking Mautic from moving forward with PHP 8. Happy to add tests or anything to move this forward :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #653, the templating engine was removed in favor of Twig. PHP templates have been deprecated in Symfony 4.3 and removed in Symfony 5.
However, in https://github.com/mautic/mautic we still heavily rely on PHP templates and are not ready to move to Twig templates just yet, as there's a lot of technical debt involved. Symfony 4.4 will be supported until November 2022 and will receive security fixes until November 2023. Would you please consider re-adding the template engine for now? Otherwise we can't get PHP 8.0 support to Mautic as soon as you release v2 of this bundle.
Thanks in advance!