Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: search history text overflows if search term is long #6728

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ozrendev
Copy link

@ozrendev ozrendev commented Feb 2, 2025

Fix search history text overflows if search term is long

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #6727

Description

Truncates text that exceeds the length of the search history input

Screenshots

Before
2025-02-02_17-09-46

After
2025-02-02_17-10-27

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 2, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 2, 2025 04:32
@absidue
Copy link
Member

absidue commented Feb 2, 2025

When making UI changes it is always a good idea to provide before and after screenshots. Please re-add the parts of the template that you removed and add screenshots to it.

Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we wanted to introduce this feature i pointed out that the users werent able to see the full search query, Unable to see full search suggestion

Reply

By fixing the overflow you introduce the issue i pointed out before

VirtualBoxVM_p5c7tA4xB7

@ozrendev
Copy link
Author

ozrendev commented Feb 2, 2025

When we wanted to introduce this feature i pointed out that the users werent able to see the full search query, Unable to see full search suggestion

Okay I wasn't aware that was an issue. Was there a decision made about how it should look?

This is what is looks like when the text contained and wrapped. Otherwise I guess you can keep the ellipsis cut off but have an alt text/tooltip when hovered over?
2025-02-02_17-02-19

@efb4f5ff-1298-471a-8973-3d47447115dc

This is how it looked before

VirtualBoxVM_AOBkZtRQvy.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: search history text overflows if search term is long
3 participants