Remove buggy VA-API on Linux flag #6489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
kommunarr
approved these changes
Dec 30, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 31, 2024
ChunkyProgrammer
approved these changes
Dec 31, 2024
github-actions
bot
removed
the
PR: waiting for review
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove buggy VA-API on Linux flag
Pull Request Type
Related issue
Description
We added the VA-API flag to enable hardware acceleration on more Linux devices, however as it is causing the video player to crash for quite a few users and broken video output for others, the feature is clearly not ready to be enabled by default in FreeTube. Users that have a setup that supports VA-API and it doesn't cause FreeTube to break can still manually pass this flag on the command line when running FreeTube.
We can reconsider re-adding it in the future when it is more stable, although when Chromium considers it stable enough, they will probably enable it by default anyway.
Desktop