Support saving screenshots as WebP files #6263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Dec 2, 2024
PikachuEXE
reviewed
Dec 3, 2024
src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
Outdated
Show resolved
Hide resolved
absidue
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 6, 2024
ChunkyProgrammer
approved these changes
Dec 6, 2024
PikachuEXE
approved these changes
Dec 6, 2024
github-actions
bot
removed
the
PR: waiting for review
jlvivero
pushed a commit
to jlvivero/FreeTube
that referenced
this pull request
Dec 7, 2024
* Support saving screenshots as WebP files * Simplify screenshot quality handling
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
* Support saving screenshots as WebP files * Simplify screenshot quality handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support saving screenshots as WebP files
Pull Request Type
Related issue
Description
This pull request adds support for saving screenshots as WebP files. The other two requested formats are not possible as explained in my comment on that feature request (TL;DR Chromium doesn't support encoding to AVIF and doesn't support JPEG XL at all, not even displaying them), so I feel like it is appropriate to close it even if we only implement support for saving as WebP files.
Testing
Take some screenshots with the WebP format selected, you can also experiment with the quality setting to see how it affects the file size and visual quality.
Desktop