Fix 'shaka-video-container' class being removed from video container #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Class shaka-video-container is added by shaka-player at
https://github.com/shaka-project/shaka-player/blob/v4.11.11/ui/controls.js#L882
ChunkyProgrammer
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 6, 2024
absidue
approved these changes
Nov 7, 2024
github-actions
bot
removed
the
PR: waiting for review
6 tasks
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 'shaka-video-container' class being removed from video container
Pull Request Type
Related issue
further resolves #5838
Description
When Vue adds dynamic classes to the video container for full window mode or forcing a 16:9 aspect ratio, the
shaka-video-containerclass is inadvertently removed from the video container element.Because the upstream CSS that hides the cursor is applied to
.shaka-video-container.no-cursor, this results in the cursor no longer hiding when viewing 4:3 aspect ratio videos or after toggling full window mode on any video.Screenshots
Testing
Before fix:
View a 4:3 aspect ratio video or toggle full window mode on any video, see that the
shaka-video-containerclass is improperly removed from the video container element and that the cursor is not properly hidden.After fix:
View a 4:3 aspect ratio video or toggle full window mode on any video, see that the
shaka-video-containerclass remains and that the cursor is properly hidden.Desktop
Additional context