Fix search box crash #6085
Merged
Fix search box crash #6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
kommunarr
approved these changes
Nov 3, 2024
ChunkyProgrammer
approved these changes
Nov 3, 2024
PikachuEXE
approved these changes
Nov 4, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 4, 2024
* fix/storyboard: ! Revert unintended change Fix search box crash (FreeTubeApp#6085) Translated using Weblate (Icelandic) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Estonian) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (German) Translated using Weblate (Arabic) Translated using Weblate (French)
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix search box crash
Pull Request Type
Related issue
Description
So this one was a weird one to investigate and I'm still not sure how any of the things are connected but this seems to fix it. The crashlog says that it crashed in an sqlite function, it only crashes with the on-screen keyboard in Windows but not with physical ones, it only happens with the main search bar not the Invidious instances one despite both having search suggestions and the fix is removing some invalid HTML?
The
listattribute on the<input>element is meant to contain the ID of a<datalist>element, in FreeTube we were pointing it to the ID of a<ul>element. This seems to cause problems with the on-screen keyboard in Windows, no idea why that invalid HTML crashes the entire page with the on-screen keyboard but has zero impact with a physical keyboard.https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#list
Testing
As I don't have access to a Mac, I haven't be able to confirm if this fixes the crash that macOS users were mentioning on that issue or if it is unrelated.
Desktop