Add: Gruvbox color schemes & accent colors

[DontBlameMe99]

Gruvbox theme

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #3987

Description

This pull request implements the Gruvbox Dark and Gruvbox Light color schemes.
It also adds all the accent colors (Red, Green, Yellow, Blue, Purple, Aqua and Orange), which were taken from the dark color palette.

Screenshots

Testing

I checked all the theme colors in both the dark, and the light variant.

Context

This pull request was created since the original one #4805 has been closed/stalled for quite some time.
I have created this from scratch, without looking at the other pull request, I hope this is fine.

[DontBlameMe99]

@kommunarr I tried to understand it and came up with this. Is this something like that what you were talking about?

.mainGruvboxLightOrange,
.mainGruvboxLightRed,
.mainGruvboxLightBlue,
.mainGruvboxLightPurple {
  --text-with-main-color: #fbf1c7;
}

.mainGruvboxDarkGreen,
.mainGruvboxDarkYellow,
.mainGruvboxDarkAqua,
.mainGruvboxDarkOrange {
  --text-with-main-color: #3c3836;
}

.mainGruvboxDarkBlue,
.mainGruvboxDarkPurple {
  --text-with-main-color: #1d2021;
}



.secGruvboxLightOrange,
.secGruvboxLightRed,
.secGruvboxLightBlue,
.secGruvboxLightPurple {
  --text-with-accent-color: #fbf1c7;
}

.secGruvboxDarkYellow,
.secGruvboxDarkGreen,
.secGruvboxDarkAqua,
.secGruvboxDarkOrange {
  --text-with-accent-color: #3c3836;
}

.secGruvboxDarkBlue,
.secGruvboxDarkPurple {
  --text-with-accent-color: #1d2021;
}

[DontBlameMe99]

@kommunarr Pinging you again because you might have missed my last message?

[kommunarr]

Hi @DontBlameMe99, sorry, I have been on a minor hiatus. That looks good to me! Note that I did leave out the other CSS variables that those blocks update in other theme colors for the sake of brevity, but make sure those are included as well.

[DontBlameMe99]

@kommunarr I am glad you are back!
I have implemented the changes and it should be just as you requested.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Everything LGTM, will approve when @kommunarr signs off

[kommunarr]

I think there's a missing CSS variable for the Gruvbox Light colors(' secondary version?), as the sliders are missing their bars.

[DontBlameMe99]

@kommunarr Really good catch! Thanks for letting me know!
Fixed in the latest commit.

[kommunarr]

LGTM!

[PikachuEXE]

Seems right but I will let one more person to review it

[ChunkyProgrammer]

Lgtm as well

[kenthinson]

@DontBlameMe99 Hello! Loving the theme you made thanks a bunch! I did have one comment that I think might improve how it looks next to other public themes. I opened a discussion about it because I did not know about this merge request. If you have time would you take a look at my screen shots and see if you think the changes mentioned are warranted to your theme? If you don't agree it's okay I'll keep my own fork going.

#6427

[DontBlameMe99]

@DontBlameMe99 Hello! Loving the theme you made thanks a bunch! I did have one comment that I think might improve how it looks next to other public themes. I opened a discussion about it because I did not know about this merge request. If you have time would you take a look at my screen shots and see if you think the changes mentioned are warranted to your theme? If you don't agree it's okay I'll keep my own fork going.

#6427

Hey @kenthinson,
I’m happy to hear you’re enjoying the theme!
As @efb4f5ff-1298-471a-8973-3d47447115dc mentioned in their reply (#6427 (comment)), the project aims to maintain readability for everyone, which means we’re unable to make changes to the color scheme. While I understand your preference for a cleaner look, we must prioritize maintaining good contrast for accessibility. If you find a way to achieve your preferred look while ensuring the contrast stays intact, that could work, but otherwise, it’s not something that can be adjusted.

For example, your new background color (#3C3836) has very poor contrast with the red color (#F44336). You can see this here: contrast checker.

Thanks for your understanding!