-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurations for linting scripts and add global ignores #5843
Add configurations for linting scripts and add global ignores #5843
Conversation
Could you please optimise the ignore patterns according to the docs: https://eslint.org/docs/latest/use/configure/ignore
You can test the performance of the patterns by calling ESLint without passing any files on the command line, that way it gathers the files to check based on the config file: |
Sorry for only commenting this now, but I wanted to test it on my computer before I commented. The eslint docs mention that
|
Co-Authored-By: PikachuEXE <[email protected]>
Add configurations for linting scripts and add global ignores
Pull Request Type
Related issue
It seems like the default recommended javascript config was being applied to our scripts files and this was causing issues with lefthook trying to lint the files
Description
I added a specific config for our _scripts folder so we can still use eslint for those files. I also moved some of the ignores to the top of the script which serves as a global ignores (it will apply to all rule below)
Screenshots
Before:
After:
Desktop