Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subscription details from search results #5795

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Update subscription details from search results #5795

merged 1 commit into from
Oct 5, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Oct 4, 2024

Update subscription details from search results

Pull Request Type

  • Feature Implementation

Related issue

Description

This pull request updates the subscription details when the search results contain channels that the user is subscribed too. At the moment we only do it for items of the type channel, but in the future we could expand it to video results too, as YouTube shows the channel thumbnails on their end but we don't parse that information yet.

Testing

  1. Download this file (remove the .txt file extension) and import it into FreeTube: subscriptions.csv.txt
  2. Open the search filters
  3. Set the type to channels
  4. Search for YouTube
  5. The channel thumbnail should have appeared in the side bar

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 68538c7

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 4, 2024 16:49
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 4, 2024
@FreeTubeBot FreeTubeBot merged commit ecb2d7d into FreeTubeApp:development Oct 5, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 5, 2024
@absidue absidue deleted the subs-channel-search branch October 5, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot