Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eslint 8 > 9 #5777

Merged
merged 7 commits into from
Oct 6, 2024
Merged

Upgrade eslint 8 > 9 #5777

merged 7 commits into from
Oct 6, 2024

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Oct 1, 2024 •
edited
Loading

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

  • Can't use --ext anymore, and using blob like ./**/*.js is very slow compared to specific folders, so only 2 folders are specified for js/vue files
  • Separate config files for json/yaml files due to I can't avoid recommended config from being applied on them
  • Draft until [New] support eslint 9 import-js/eslint-plugin-import#2996 released

Screenshots

image

Testing

  • yarn run lint
  • yarn run lint-json
  • yarn run lint-yml

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@PikachuEXE PikachuEXE added the PR: dependencies Pull requests that update a dependency file label Oct 2, 2024
@PikachuEXE
Copy link
Collaborator Author

Since we can switch from standard to neostandard later maybe we can just upgrade to ESLint 9 first?

ChunkyProgrammer
ChunkyProgrammer reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely try to fix: Separate config files for json/yaml files due to I can't avoid recommended config from being applied on them

Since IDEs/code editors wont be able to highlight the issues

eslint.yaml.config.mjs Outdated Show resolved Hide resolved
eslint.json.config.mjs Outdated Show resolved Hide resolved
absidue
absidue reviewed Oct 3, 2024
View reviewed changes
eslint.config.mjs Outdated

settings: {
'vue-i18n': {
localeDir: './static/locales/{en-US,en-GB,ar,bg,ca,cs,da,de-DE,el,es,es-AR,es-MX,et,eu,fa,fi,fr-FR,gl,he,hu,hr,id,is,it,ja,ko,lt,nb-NO,nl,nn,pl,pt,pt-BR,pt-PT,ro,ru,sk,sl,sr,sv,tr,uk,vi,zh-CN,zh-TW}.yaml',
Copy link
Member

@absidue absidue Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please import the list instead of hardcoding it, so that we don't have to maintain it in multiple places. Using import activeLocales from './static/locales/activeLocales.json' with { type: 'json' } and then calling .join(',') on the imported array should work.

According to the history drop down on https://nodejs.org/api/esm.html#import-attributes the with keyword is supported in Node 21+ and in the LTS versions 18.20+ and 20.10+, so we should be fine using it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With dynamic import, got warning (probably non issue assuming it eventually no longer Experimental

const { default: activeLocales } =
  await import('./static/locales/activeLocales.json', { with: { type: 'json' } })

image

Also static import would only cause syntax error with node 20.17.0
image
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason it didn't work with the static import is because of the missing : between type and 'json'.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@PikachuEXE
Copy link
Collaborator Author

@ChunkyProgrammer config files merged
Turns out localeDir needed in all config blocks (even for json/yaml

@PikachuEXE PikachuEXE marked this pull request as ready for review October 5, 2024 03:13
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 5, 2024 03:13
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 5, 2024
absidue
absidue reviewed Oct 5, 2024
View reviewed changes
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows CMD doesn't interpret single quotes, so it passes them through to eslint and then eslint fails to find files that start and end with single quotes. I've suggested changes to switch to double quotes instead.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
absidue
absidue reviewed Oct 5, 2024
View reviewed changes
eslint.config.mjs Outdated Show resolved Hide resolved
eslint.config.mjs Outdated Show resolved Hide resolved
@PikachuEXE
Copy link
Collaborator Author

Updated~

@FreeTubeBot FreeTubeBot merged commit 89624a5 into FreeTubeApp:development Oct 6, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 6, 2024
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Oct 7, 2024
@PikachuEXE
Merge branch 'development' into feature/history/remember-search-query
707f950 
* development: (55 commits)
  Translated using Weblate (Russian)
  Translated using Weblate (Japanese)
  fix cmd+m shortcut to minimize the window on macos and not mute the video (FreeTubeApp#5828) (FreeTubeApp#5829)
  Update dependabot.yml to add new eslint packages into the eslint group (FreeTubeApp#5837)
  Bump the babel group with 4 updates (FreeTubeApp#5831)
  Bump globals from 15.9.0 to 15.10.0 (FreeTubeApp#5835)
  Bump lefthook from 1.7.17 to 1.7.18 (FreeTubeApp#5836)
  Bump the eslint group with 2 updates (FreeTubeApp#5832)
  Bump @eslint/js from 9.11.1 to 9.12.0 (FreeTubeApp#5833)
  Bump @eslint/compat from 1.1.1 to 1.2.0 (FreeTubeApp#5834)
  Translated using Weblate (Belarusian)
  Translated using Weblate (Hebrew)
  Translated using Weblate (Chinese (Traditional Han script))
  Turn `vue/no-useless-template-attributes` eslint rule back on (FreeTubeApp#5830)
  Translated using Weblate (Serbian)
  Translated using Weblate (Belarusian)
  Translated using Weblate (Belarusian)
  Translated using Weblate (Belarusian)
  Upgrade eslint 8 > 9 (FreeTubeApp#5777)
  Translated using Weblate (Belarusian)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

Assignees
No one assigned
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot