Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update top nav to move query text to new window instead of remaining in old window #5541

Merged

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Aug 8, 2024

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

When entering text into top nav and opening a new window via shift click/enter
It's weird to me that the query text stayed on the old window instead of inside the top nav of the new window

This PR makes FT "moves" the query text to the new window (only if new window created) and for hashtag I use #hashtag due to how case 'search' works (can be changed back to query text which can be URL let me know)

Screenshots

After new window opened I switch back to old window and then to new window again

Screen.Recording.2024-08-08.at.08.41.27.mp4

Testing

  • Enter different kinds of text (URLs, hash tags...) into top-nav
  • Shift click/enter to open new window
  • Ensure text on new window top-nav and not on old window one

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 8, 2024 00:44
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 8, 2024
@FreeTubeBot FreeTubeBot merged commit 27d7ba6 into FreeTubeApp:development Aug 12, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants