Fix error when fetching deleted comment replies in local API #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
There was a problem hiding this comment.
This isnt a big of an issue but i will mention it nonetheless
On first click it will change into Hide reply -> Click on Hide reply changes into Show reply -> Click on Show reply -> see that it doesnt change to Hide reply
VirtualBoxVM_2MA3RQB01F.mp4
Q: Should it even transition to Hide reply if there are no replies? Why not just stay on Show reply?
|
No idea how to properly deal with this kind of edge cases (replies all deleted) However if we follow Youtube it does the same thing |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 12, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
absidue,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
kommunarr
approved these changes
Jun 12, 2024
absidue
approved these changes
Jun 12, 2024
github-actions
bot
removed
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
deleted the
fix/get-deleted-reply-error
branch
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 13, 2024
* development: (60 commits) check for 204 error (FreeTubeApp#5259) Translated using Weblate (Turkish) ! Fix error when fetching deleted comment replies in local API (FreeTubeApp#5255) Optical enhancement - Improved spacing on the about page FreeTubeApp#5210 (FreeTubeApp#5257) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Estonian) Translated using Weblate (German) Update playlist page to add remove duplicate videos button for user playlists (FreeTubeApp#5191) Respect playlist sort order in `watch-video-playlist` (FreeTubeApp#5013) Translated using Weblate (Serbian) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Arabic) Translated using Weblate (Polish) Translated using Weblate (Italian) Translated using Weblate (Turkish) Translated using Weblate (Croatian) Translated using Weblate (Dutch) Translated using Weblate (Spanish) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Pull Request Type
Related issue
Description
There is an error when trying to get replies for a comment but all replies deleted
This PR removes that error toast for Local API (no idea how to fix IV API)
Screenshots
Testing
Hi TrainDailyon first pageDesktop
Additional context