Fix ft-prompt closing when clicking elements with role="button"

[MarmadileManteater]

Fix ft-prompt closing when clicking elements with role="button"

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Description

There does not seem to be any cases of role="button" currently within an ft-prompt except for within the ft-input in the add video to playlist prompt. In that case, the search clear button has role="button", and hiding the whole prompt when it is clicked doesn't seem like intentional behaviour. I find it jarring as it overrides what the button is supposed to do (clear the search bar) with seemingly unintended functionality (close the whole prompt). This PR addresses this by removing the check for elements with role="button" within the handleHide method of ft-prompt.

Screenshots

before	after

Testing

1. Open the add video to playlist prompt
2. Click the X button within the ft-input component
3. Ensure the ft-prompt does not close

Desktop

• OS: Windows 10
• OS Version: 22H2 (OS Build 19045.4291)
• FreeTube version: 71b7c60

Additional context

On the chance that there is some usage of this check in the app currently which I overlooked, I would reason that it should be adjusted by modifying the click event on UI elements that need this functionality rather than having a case for it within the ft-prompt itself.

This change should make it easier to add ft-icon-buttons to a prompt in the future since they all use role="button".

[efb4f5ff-1298-471a-8973-3d47447115dc]

Nice catch @MarmadileManteater :)