Filter settings sections at build time instead of run time #5040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Apr 30, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 30, 2024
ChunkyProgrammer
approved these changes
Apr 30, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter settings sections at build time instead of run time
Pull Request Type
Related issue
Follow up to #5010
Description
Filtering settings sections at build time instead of run time, means we have a bit less work to do at runtime and also shaves off 52 bytes from the renderer.js file and 556 bytes from the web.js file.
Testing
yarn run dev: Check that the Electron specific settings still show up (download, proxy, external player, experimental)yarn run dev:webCheck that the Electron specific settings are not displayed.Desktop