Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement minor settings section visual fixes & height change #4343

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Implement minor settings section visual fixes & height change #4343

merged 1 commit into from
Nov 23, 2023

Conversation

kommunarr
Copy link
Collaborator

Implement minor settings section visual fixes & height change

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

none

Description

  • Resolves Settings Section border width bug (media query in only one place at 750px)
  • Remediates Sections Section differing border widths subpixel bug (was worsened by changing zoom levels and especially apparent/annoying at a lower zoom level)
    • Discussion: subpixel issue
  • Sets Settings Section margin-block to 0.5em from previous value of 1em (looks cleaner and keeps all sections in frame on load at default zoom for most devices)

Screenshots

Border width bug:

Before After
Screenshot_20231116_221317 Screenshot_20231116_221337

Subpixel bug:

Before After
Screenshot_20231116_221654 Screenshot_20231116_221710

Testing

  • Place browser viewport width below 750px and confirm settings section border lengths are preserved
  • Increase and decrease zoom levels, while ensuring settings section border widths are not noticeably uneven

Desktop

  • OS: OpenSUSE Tumbleweed
  • OS Version: 2023xxxx
  • FreeTube version: 0.19.1

Additional context

Technically this is the "best" solution to the subpixel issue, but medium is a bit too thick, and thin is a bit too thin, in my opinion. This current solution resolves any noticeable subpixel oddities as per my testing.

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 17, 2023 04:32
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 17, 2023
PikachuEXE
PikachuEXE approved these changes Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks small now lol

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FreeTubeBot FreeTubeBot merged commit 7e61e53 into FreeTubeApp:development Nov 23, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue Awaiting requested review from absidue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kommunarr @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot