-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local API: Add support for hashtag pages #3483
Local API: Add support for hashtag pages #3483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested https://www.youtube.com/hashtag/pikachu
However I think we need more stuff tested. such as hashtag in video description
Example video with tags in description: https://youtu.be/v6jw6KRIOmw
Co-authored-by: absidue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool if you could do something similar to what we do with the channel handles, so that you can search for #shorts
without needing to type out the full https://youtube.com/hashtag/shorts
URL.
The |
I'll add that later tonight (if i have time) |
Co-Authored-By: absidue <[email protected]>
Im not sure if i like searching for hashtags like that. With @[insert channel name] its clear u searching for the channel because it is mostly used for that. With hashtags i get other results if i search it normally vs this special hashtag tab. FreeTube_SSyrO3BSrz.mp4Lets say im looking for that episode but only remembering finding it on yt using these keywords. On FT u can never find it again. |
Co-authored-by: absidue <[email protected]>
Is it possible for u to implement the #search come up in the search results in this PR? |
I dont think it's supported by invidious nor youtube.js at the moment |
Local API: Add support for hashtag pages
Pull Request Type
Description
This PR adds support for YouTube hashtag pages when the local api is enabled.
It is not added for Invidious because:
Invidious does not currently have api support for hashtag pages. See: API: Add hashtag endpoint iv-org/invidious#3692
The hashtag page is currently not working for invidious. See: Hashtags are broken - "Request contains an invalid argument" iv-org/invidious#3778
Screenshots
Testing
Search test
https://www.youtube.com/hashtag/cats
in the search/nav barDescription Test - Invidious
Description Test - Invidious w fallback
Description Test - Local
Desktop