Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide the header FreeTube logo #2893

Merged

Conversation

theforbiddenpool
Copy link
Contributor

Option to hide the header FreeTube logo

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #2488

Description

Adds a new toggle setting under Theme Settings to hide the FreeTube's logo on the header.

Screenshots

Screenshot_20221125_125601
The new setting.

Screenshot_20221125_125621
When the toggle is on, the logo is hidden.

Desktop

  • OS: Arch Linux
  • OS Version: --
  • FreeTube version: 0.18.0

Additional context

I wasn't quite sure where exactly to put the setting, but Theme Settings felt the most right. Let me know if I should move it somewhere else.

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 25, 2022
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 25, 2022 12:08
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@ChunkyProgrammer
Copy link
Member

Might be worth putting the toggles into seperate columns

@FreeTubeBot FreeTubeBot merged commit 064db4b into FreeTubeApp:development Nov 27, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 27, 2022
@theforbiddenpool theforbiddenpool deleted the hide-logo-option branch December 7, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Option to hide FreeTube logo on the header
5 participants