Optimise CSS and JSON files #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
added
PR: dependencies
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
absidue
force-pushed
the
optimise-css-json
branch
from
cc5f07a to
965dcd2
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
the
PR: waiting for review
PikachuEXE
previously approved these changes
Sep 12, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Sep 12, 2022
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
absidue
dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and PikachuEXE
via
0e166df
absidue
force-pushed
the
optimise-css-json
branch
from
965dcd2 to
0e166df
Compare
absidue
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 12, 2022
ChunkyProgrammer
approved these changes
Sep 12, 2022
PikachuEXE
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimise CSS and JSON files
Pull Request Type
Description
Optimise the CSS and JSON files during production builds. This unfortunately doen't make a big difference but I guess it's better than nothing. It is annoying that css-minimizer-webpack-plugin adds so many new development dependencies.
Screenshots (if appropriate)
distdirectory:app.asar:Testing (for code that is not small enough to be easily understandable)
yarn devandyarn buildDesktop (please complete the following information):