Watch: Fix "Show More Replies" button visibility condition #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Svallinn
requested review from
absidue,
ChunkyProgrammer,
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
PikachuEXE
approved these changes
Aug 7, 2022
There was a problem hiding this comment.
Tested locally with https://www.youtube.com/watch?v=cMIgU6YlsEw
(URL provided in description is incorrect)
absidue
approved these changes
Aug 7, 2022
Sneaky comma impostor :P |
|
I can't even guess the reason there is comma... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select what type of pull request this is:
Related issue
None
Description
YouTube's reply count is unreliable. If I had to wager a guess, it's probably because comments that have been flagged/removed by the system don't decrement the counter at all.
This PR changes the visibility condition of the "Show More Replies" to check if the continuation token is null or not, which is, as far as I can see, reliable without a fault.
Testing / Screenshots
Tested video: https://www.youtube.com/watch?v=cMIgU6YlsEw (pinned comment)
BEFORE
AFTER