Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caption baseurl #2268

Merged
merged 2 commits into from
May 27, 2022
Merged

Fix caption baseurl #2268

merged 2 commits into from
May 27, 2022

Conversation

hockerschwan
Copy link
Contributor

Pull Request Type

  • Bugfix

Related issue
closes #2265

Description

  1. Set API to Local
  2. Set Language to anything but English (US, UK or System)
  3. Watch any video with caption and receive error.

Also remove duplicate translations in tryAddingTranslatedLocaleCaption

Screenshots (if appropriate)
Before: API Error

After:

Desktop (please complete the following information):

  • OS: Windows 10 21H1
  • FreeTube version: 2332aaf

@PrestonN PrestonN enabled auto-merge (squash) May 25, 2022 08:48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 25, 2022
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on MacOS 12.1

Copy link
Member

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PrestonN PrestonN merged commit c098014 into FreeTubeApp:development May 27, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 27, 2022
@hockerschwan hockerschwan deleted the fix_caption_baseurl branch May 27, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Many API errors
5 participants