Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/SearchHistoryDuplicate #2124

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Fix/SearchHistoryDuplicate #2124

merged 1 commit into from
Mar 26, 2022

Conversation

hockerschwan
Copy link
Contributor

@hockerschwan hockerschwan commented Mar 14, 2022

Title

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation

Related issue
closes #2123
closes #1659

Description
Fix addToSessionSearchHistory in utils.js
(payload.data is already concatenated in Search.js)

Screenshots (if appropriate)
First page
1

No duplicates
2

Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Please describe shortly how you tested it and whether there are any ramifications remaining.

search ltt >
click on fetch more results >
wait a few seconds >
press the backward button on the left top side of the screen >
press the forward button on the left top side of the screen >
see duplicated videos/channel

Desktop (please complete the following information):

  • OS: Windows10
  • OS Version: 21H1
  • FreeTube version: 0.16.0

payload.data is already concatenated in Search.js
@PrestonN PrestonN enabled auto-merge (squash) March 14, 2022 02:15
@efb4f5ff-1298-471a-8973-3d47447115dc

Also closes #1659

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 14, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything lgtm only have one request

Copy link
Member

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PrestonN PrestonN merged commit dc4a828 into FreeTubeApp:development Mar 26, 2022
@hockerschwan hockerschwan deleted the Fix/SearchHistoryDuplicate branch March 26, 2022 02:16
@hockerschwan hockerschwan restored the Fix/SearchHistoryDuplicate branch March 26, 2022 02:16
@hockerschwan hockerschwan deleted the Fix/SearchHistoryDuplicate branch March 26, 2022 02:16
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants