Settings Section order #1739
Comments
|
Yeah i agree that sorting it alphabetically is not feasible. I do like the second suggestion tho. It would be really nice if the user can select where they want the setting to be. |
|
I haven't had a problem with this personally, but I do think this kind of permanent customization of list-like elements could be useful. Here are a few related issues: #1717 #987 #958 #17. Sorting by recency of use, sorting alphabetically, sorting manually, and "hiding" some selections seem to be all of the suggestions. If you did want to end up applying this capability to so many different kinds of lists (profiles, subscriptions, dropdown settings, app settings), you could add a button near them that would open a settings modal. |
|
Still dont like the way its not ordered alphabetically tho. Looks like a big mess.
|
|
Not sure if it belongs here and wanted to open up an issue for this but i thought maybe i can ask it here. If u think this doesnt belong here and i should or should not open an issue about it pls let me know. Hiding everything related to invidious when invidious is not selected as API. I mean there are people that dont even use that api and it maybe uses to much screen real estate. So why show me if im never ever going to do anything with it? Its just unnecessary in my opinion. Same here why show all of the related settings when its not even enabled? |
|
@efb4f5ff-1298-471a-8973-3d47447115dc This is partially addressed in #1822. In particular, the Proxy Settings are now grayed when "Enable Tor/Proxy" is disabled. Are you still of the opinion that it should just disappear instead of being grayed out? Similarly, are you still of the opinion that "Current invidious instance" should disappear when "Fallback to Non-Preferred Backend on Failure" is set to false & Preferred API Backend is set to "Local API"? (This second case is not grayed out in #1822 at this time.) My concern is that removing them instead of just graying them could cause confusion for people unfamiliar with that interaction who are looking for that functionality. Edit: Added screenshots of such an implementation in #1822 & have it completed on my local branch. |
|
As discussed in IRC, graying out will be just fine! |
efb4f5ff-1298-471a-8973-3d47447115dc
added
E: visual improvement
and removed
UI/style
labels
efb4f5ff-1298-471a-8973-3d47447115dc
added
enhancement
Solving the problem of preventing 'jumping around' when changing locales with alphabetical sorting is hard. This problem is easily solved by stickying general settings to the top of the list unconditionally. This is in line with ChunkyProgrammer's initial assessment of how to improve the settings order in FreeTubeApp#1739, albeit not also moving Theme Settings to the top for the time being. The rationale from a functional level is that General Settings is a hub. Even when you change languages, change sort order, or what have you, General Settings is right at the top. I don't imagine we need to update the label of the setting, as I think this relationship is quite intuitive.
* Implement settings section sorting * Make IS_ELECTRON property used directly * Implement settings menu with icons * Implement short labels and fallback to longer label when translation doesn't exist * Implement dynamic scroll-based underlining of active section * Ensure General Settings is always first, ignoring sorting Solving the problem of preventing 'jumping around' when changing locales with alphabetical sorting is hard. This problem is easily solved by stickying general settings to the top of the list unconditionally. This is in line with ChunkyProgrammer's initial assessment of how to improve the settings order in #1739, albeit not also moving Theme Settings to the top for the time being. The rationale from a functional level is that General Settings is a hub. Even when you change languages, change sort order, or what have you, General Settings is right at the top. I don't imagine we need to update the label of the setting, as I think this relationship is quite intuitive. * Styling & documentation improvements; remove problematized Hot Pink link underline removal experiment * Implement bare minimum mobile styling * Increase link padding * Fix underline to be equal on both sides * Update to have first section active by default * Make constant for 'active' class name * Replace proxy icon with more fitting one * Move shortTitle logic * Update scrolling logic to not use anchor links * Implement mobile view for Settings Menu * Replace rounded corners and move section titles to the interior * Update font sizes and breakpoints to work for all supported devices & languages * Update as per review comments * Make class-specific constants declared in file * Update settings menu link sizing to be dynamic to better accommodate mobile/tablet devices * Focus active menu on mobile close * Replace shortTitle with title, & replace EN-US labels with shorter forms * Update menu font size for mobile devices * Focus section heading on navigating to it in desktop view --------- Co-authored-by: Jason <[email protected]>
Topic
Please select what topic your discussion is about.
Discussion
Please write down whatever you want to discuss.
I don't believe that the order that setting headers are presented in is optimal
I feel like something like General then Theme then do the rest in alphabetical order would be better but the alphabetical order would change for different langauges so I don't think this would be ideal. Another option would be to save the order of the settings and allow user's to drag the headings to customize them. I think a more accessible and easier way to implement this would be to just add arrows going up or down to the headers when a button called "Customize Headers" is clicked. Thoughts?
The text was updated successfully, but these errors were encountered: