Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping the "Subscriptions"/"Most Popular" reload button fixed while scrolling #1043

Closed
orthand opened this issue Feb 19, 2021 · 3 comments · Fixed by #1573
Closed

Keeping the "Subscriptions"/"Most Popular" reload button fixed while scrolling #1043

orthand opened this issue Feb 19, 2021 · 3 comments · Fixed by #1573
Assignees
Labels
enhancement New feature or request

Comments

@orthand
Copy link

orthand commented Feb 19, 2021

Describe the solution you'd like to see implemented
Additionally to #1010 keeping the "Subscriptions"/"Most Popular" reload button fixed/static in the right corner while scrolling.

Describe alternatives you've considered
Adding a "scroll to top" arrow/button in the lower right corner could be an alternative (or an additional function in general). On touch devices with detachable keyboards this would help with excessive scrolling.

Additional context
I really like the timestamp idea from #1010 for the "Subscriptions" section. Though this would make the static field too large to keep it next to the reload button while scrolling and therefore interfere with the shown videos. I wouldn't want another bar on top that takes up more space so I thought of either

  • trying to add the timestamp beneath the button
  • only showing it when hovering over the reload button
  • in addition to the second point: also show when (stationary) in the top position while there is still space above the videos.
@orthand orthand added the enhancement New feature or request label Feb 19, 2021
@orthand orthand changed the title Keeping the "Subscriptions" reload button fixed while scrolling Keeping the "Subscriptions"/"Most Popular" reload button fixed while scrolling Feb 19, 2021
@saideepesh000
Copy link
Contributor

@PrestonN @GilgusMaximus can I work on it.

@GilgusMaximus
Copy link
Contributor

GilgusMaximus commented Feb 27, 2021

Hi,
so thanks for your ambition to help on this feature !
I'll go ahead and assign you to this issue.

One thing to keep in mind here is that we need some testing for different window sizes. Especially for very thin windows like below, either adjusting the size/placement of the reload button, or disabling the fixed position for scrolling might be a solution to avoid overlapping. If you need any input feel free to ask and open a PR where this can be discussed.

Edit: Going for disabling that feature if the window is too small, depending on how it is done, might be a better idea than resizing, because then the whole static position while scrolling can be toggled on and off in the settings page regardless of the window size.

image

Best Regards,
Gilgus

@kommunarr
Copy link
Collaborator

Communicated with @saideepesh000 over email and mutually agreed to transfer assignment on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants