Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show when subscriptions were last updated #1010

Closed
Donkey-Doug opened this issue Feb 2, 2021 · 15 comments · Fixed by #4380
Closed

Show when subscriptions were last updated #1010

Donkey-Doug opened this issue Feb 2, 2021 · 15 comments · Fixed by #4380
Assignees
Labels
enhancement New feature or request

Comments

@Donkey-Doug
Copy link

I suggest showing the date and time of the latest subscriptions refresh time. See screenshot below:

last updated

@kommunarr
Copy link
Collaborator

Looking at this now. The problem is that this section overlaps with the videos at ~800px wide (in the en-US locale, at least). Which of these solutions do others prefer?

  1. Add a --card-bg-color theme color background behind the date time text.
  2. Keep the date information kept in that one place, not fixed as the user scrolls down.
  3. Start having the entire "Videos / Short / Live / Community" portion stay fixed as the user scrolls, and affix the refresh button & timestamp to the right shoulder of that.
  4. Hide the date information once it starts overlapping with the videos (will have to choose a pretty high minimum screen width to account for different locales - at least 1000px).

Screenshot_20231118_183013

@efb4f5ff-1298-471a-8973-3d47447115dc

What about putting it left of the refresh button?

@kommunarr
Copy link
Collaborator

I can do that, but still needs a fix for the overlapping issue.

@efb4f5ff-1298-471a-8973-3d47447115dc

Would be nice if the text hot the same behavior as the refresh button. So the user can still see it no matter how far they scroll down.

Because of this Im not a fan of nr 4 to just hide it.

@kommunarr
Copy link
Collaborator

@efb4f5ff-1298-471a-8973-3d47447115dc Thoughts on this implementation of #1?

Screenshot_20231119_095926
Screenshot_20231119_095858

@efb4f5ff-1298-471a-8973-3d47447115dc

Looks good to me.

Just remembered two things:

  1. Should we also do this for the trending and most popular page?
  2. What will this look like If all the refresh buttons going to be replaced by one? Maybe this is something that we don't have to think about now but i just want to put it out here.

Context: We wanted to include a reload button on the player page because the player frequently broke back in the day and then the decision was made to maybe replace all refresh buttons by one.

Maybe we don't have to replace all buttons anymore because player doesn't break that often anymore?

@kommunarr
Copy link
Collaborator

kommunarr commented Nov 19, 2023

Good Q - and a third one is "separate one for Shorts, Live, & Community" v.s. "just hide it in those cases". I'm thinking hide it, because it just doesn't seem worth the effort unless someone genuinely puts in a request for something like that.

And in the spirit of expanding the scope, there's a fourth one of "What if you always want to know when the data was grabbed on any given page?" (Channels, Video, Playlist) But I think this one should be a "No."

And while on this tangent, maybe something like this for settings. Probably no because no one has asked for that.

Sorry, back to the original: it does make sense to do it for Trending and Most Popular, but to prevent code duplication we would have to make the refresh button its own component. Which does feel silly if we are thinking about just wiping it with an app-wide refresh button.

....BUT. an app-wide refresh button that replaces this sounds like not a good idea? It's honestly pretty confusing as a developer to think about what we would program it to do on each route at a requirements level, so I imagine users would feel the same way ("Does this just do a Ctrl+R on this route? It does something different when I'm watching a video." "Where is the button?" "I hate when apps move the controls around to new places, it's so confusing and frustrating.")

So I think we should at the very least keep this old refresh button around as its own thing. We have to add it as its own reusable component if we want to add it to anything else than main video subscriptions at the moment, so I'm leaning towards just doing it for Video Subscriptions and expand the feature if we get any request for it. But currently, I don't have evidence that there's any demand for it to warrant the effort for 1 or 3, which is my main modus operandi I try to keep in mind when working on features.

Edit: sorry, misclicked and accidentally closed

@kommunarr kommunarr reopened this Nov 19, 2023
@kommunarr kommunarr self-assigned this Nov 19, 2023
@kommunarr
Copy link
Collaborator

kommunarr commented Nov 19, 2023

One more sizable Q I want to float is what we would think about moving this to the left-hand side. It would be impossible to miss, so not much confusion, I would imagine, but it's also so much closer to all of the other controls that a user regularly interacts with (e.g., clicking the Subscriptions link on the side nav).

Screenshot_20231119_124235

With order flipped:

Screenshot_20231119_124626

@efb4f5ff-1298-471a-8973-3d47447115dc

Before i was in favor of replacing all the refresh buttons but after talking more about it im against it.

Your pics + NewPipe just gave me another insight in a possible route for this. Date time on the left and refresh on the right?

@kommunarr
Copy link
Collaborator

@efb4f5ff-1298-471a-8973-3d47447115dc I don't use NewPipe, could you expand a bit more on what you had in mind?

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 23, 2023

Last updated on the left and refresh stays on the right

IMG_20231123_024356.jpg

@kommunarr
Copy link
Collaborator

kommunarr commented Nov 23, 2023

@efb4f5ff-1298-471a-8973-3d47447115dc Here's what it looks like now. Thoughts?

If you do use NewPipe personally, does the timer go up as you stay on the page, or does it only recalculate when you land on it? Deciding on whether to keep it as this timestamp or a comparative unit of time as is done there (e.g., 5 days ago).

Edit: note to self, will also have to test this with the notification banner.

Screenshot_20231123_095057

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 23, 2023

@efb4f5ff-1298-471a-8973-3d47447115dc Here's what it looks like now. Thoughts?

I like it!

If you do use NewPipe personally, does the timer go up as you stay on the page, or does it only recalculate when you land on it?

Timer does not go up when u stay on the page BUT if you are on the subscriptions page and minimize your window or changing apps and come back to it the timestamp does update.

Deciding on whether to keep it as this timestamp or a comparative unit of time as is done there (e.g., 5 days ago).

I think comparative unit is simpler than the timestamp because with the timestamp u have to take into account 24hrs or 12hrs time zone and how the date is written over there.

Im probably heavily influenced by NewPipe but i like the way they do it.

< 60s = Feed last updated: Moments ago
< 60mins = Feed last updated: xx Minutes ago
< 24 hours = Feed last updated: xx Hours ago
'>=' 24 hours -> Feed last updated: xx Days ago

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 30, 2023

@jasonhenriquez Do we still want to keep #1005 open?

@kommunarr
Copy link
Collaborator

Yes, I think there's merit to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants