add default_idx parameter to QualifiedName

FreeOpcUa · Jul 28, 2023 · 340faee · 340faee
1 parent d52db70
commit 340faee
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/asyncua/ua/uatypes.py b/asyncua/ua/uatypes.py
@@ -683,15 +683,15 @@ def to_string(self):
         return f"{self.NamespaceIndex}:{self.Name}"
 
     @staticmethod
-    def from_string(string):
+    def from_string(string, default_idx=0):
         if ":" in string:
             try:
                 idx, name = string.split(":", 1)
                 idx = int(idx)
             except (TypeError, ValueError) as ex:
                 raise UaStringParsingError(f"Error parsing string {string}", ex) from ex
         else:
-            idx = 0
+            idx = default_idx
             name = string
         return QualifiedName(Name=name, NamespaceIndex=idx)
 

diff --git a/tests/test_unit.py b/tests/test_unit.py
@@ -451,6 +451,15 @@ def test_nodeid_string():
     # nid1 = ua.StringNodeId(1, 2)
 
 
+def test_qualifiedname_string():
+    qname1 = ua.QualifiedName.from_string("1:Name")
+    assert (1, "Name") == (qname1.NamespaceIndex, qname1.Name)
+    qname2 = ua.QualifiedName.from_string("Name")
+    assert (0, "Name") == (qname2.NamespaceIndex, qname2.Name)
+    qname3 = ua.QualifiedName.from_string("Name", default_idx=1)
+    assert (1, "Name") == (qname3.NamespaceIndex, qname3.Name)
+
+
 def test_bad_string():
     with pytest.raises(ua.UaStringParsingError):
         ua.NodeId.from_string("ns=r;s=yu")