Fix bug where certain server capability parameters were cast to u32 instead of u16 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is according to the OPC-UA standard.
einarmo
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Huh. These values being u16 honestly is bizarre to me. It's absolutely not inconceivable that you would want to support more than 65k continuation points on a sufficiently large server. I guess if you want that you're stuck with setting the value to 0? (We don't currently support this I think...). All that for a theoretical saving of 4 bytes...
Either way, thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the OPC-UA standard (https://reference.opcfoundation.org/Core/Part5/v104/docs/6.3.2) the following parameters should have the type uint16:
In the current implementation of the library, these parameters are cast to u32. This causes a type mismatch bug when connecting from an OPC-UA client on a B&R PLC to a server using the library. The fix was verified on that B&R PLC, but has not been tested on other PLCs.