Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore buildOptions.baseUrl configuration for %BASE_URL% replacement in dev server #957

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Ignore buildOptions.baseUrl configuration for %BASE_URL% replacement in dev server #957

merged 1 commit into from
Aug 28, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

Testing

  • No dev tests.

@FredKSchott FredKSchott requested a review from a team as a code owner August 28, 2020 21:16
@vercel
Copy link

vercel bot commented Aug 28, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/dy62xovlk
✅ Preview: https://snowpack-git-dev-public-url.pikapkg.vercel.app

gr2m
gr2m approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with @snowpack/app-template-blank, a %PUBLIC_URL% placeholder in public/index.html, and buildOptions.baseUrl configuration. Before the change the replaced value was https://mydomain.com/subdirectory/, after the change the value was /

I would suggest to rephrase the commit message to

Ignore buildOptions.baseUrl configuration for %BASE_URL% replacement in dev server

@FredKSchott FredKSchott changed the title do not include public_url in dev Ignore buildOptions.baseUrl configuration for %BASE_URL% replacement in dev server Aug 28, 2020
@FredKSchott FredKSchott merged commit 5372aab into master Aug 28, 2020
@FredKSchott FredKSchott deleted the dev-public-url branch August 28, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @gr2m