Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean unnecessary code #949

Merged
merged 1 commit into from
Aug 28, 2020
Merged

clean unnecessary code #949

merged 1 commit into from
Aug 28, 2020

Conversation

MoonBall
Copy link
Contributor

Changes

clean unnecessary code

Testing

no test needed.

@MoonBall MoonBall requested a review from a team as a code owner August 28, 2020 00:17
@vercel
Copy link

vercel bot commented Aug 28, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/1jka01duh
✅ Preview: https://snowpack-git-fork-moonball-clean-unnecessary-code.pikapkg.vercel.app

gr2m
gr2m approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and all tests are passing. So if anything breaks, our tests are to blame :) Thanks for the clean Chen!

FredKSchott
FredKSchott requested changes Aug 28, 2020
View reviewed changes
Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 small comment, marking as "request changes" only so that no one accidentally merges until that gets resolved.

snowpack/src/build/build-pipeline.ts Show resolved Hide resolved
snowpack/src/commands/build.ts Show resolved Hide resolved
@MoonBall MoonBall force-pushed the clean-unnecessary-code branch from aaf5dfe to c74fa2d Compare August 28, 2020 10:10
@MoonBall MoonBall requested a review from FredKSchott August 28, 2020 10:13
FredKSchott
FredKSchott approved these changes Aug 28, 2020
View reviewed changes
Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FredKSchott FredKSchott merged commit 843cf9e into FredKSchott:master Aug 28, 2020
@FredKSchott
Copy link
Owner

clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoonBall @FredKSchott @gr2m