[plugin-svelte] disable svelte-hmr conflicting overlay #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/15k17012j |
|
LGTM! Thanks @rixo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
svelte-hmrimplements its own error overlay, and it can conflict (be displayed at the same time) as Snowpack's one. Also, both overlays don't have the same design, so this seems pretty weird to keep both.This PR opts out of
svelte-hmroverlay to only keep Snowpack's one.Testing
Manual testing: errors that triggered
svelte-hmroverlay before the change don't trigger it anymore after the change.Docs
I think the current double-overlay situation should be considered a bug that this change is fixing.