Support secondary file extensions in resolve.input & resolve.output #… #1909
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/lva8r0cpw |
glromeo
changed the title
| // @ts-ignore: Deprecated | ||
| filePath: fileName, | ||
| filePath: filePath, |
There was a problem hiding this comment.
this seems to be changing a lot of existing behavior to use new values. our entire plugin ecosystem relies on these values not changing
There was a problem hiding this comment.
Thanks for the PR! I really appreciate the work here, but I think we're going to go in a different direction for this. It's a tricky feature to add, and I'd feel better about merging if we made fewer changes across the codebase to do it. Also, it's a good chance to get rid of extendedExt which never really delivered on dynamic length extension support.
I'm going to submit this in a separate PR. If you're testing this in your own project, I'd love for you to check out that PR and see if it works
| @@ -161,7 +162,7 @@ class FileBuilder { | |||
| continue; | |||
| } | |||
| const outFilename = replaceExt( | |||
| path.basename(url.fileURLToPath(this.fileURL)), | |||
| path.basename(filePath), | |||
There was a problem hiding this comment.
we're trying to use more file URLs instead of less, so would like to keep these as-is
…1340
Please let me know your thoughts about adding outPath to SnowpackBuiltFile
if this solution is acceptable I will tidy up the PR with tests & doc
At the moment I have a plugin which uses these changes which works both in DEV and BUILD
Changes
This tries to implement a solution for #1340
Testing
All current tests are green
TODO
Docs
NOT YET
WIP