Fix build of large css with Webpack #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/mfpin7wsd |
FredKSchott
reviewed
Dec 6, 2020
There was a problem hiding this comment.
This fix appears to work, +1 conceptually. @mxmul mind taking a look to make sure this doesn't regress anything on your end?
mxmul
approved these changes
Dec 6, 2020
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a build failure of the Webpack plugin when processing large chunks of css. This is a regression of what was first brought of in this discussion, has been fixed in PR and has been reintroduced by PR.
The new behavior adds a separate chunk for css just like is is also handled in Gatsby.
While investigating where the fix has been lost I also noticed that there are 6 commits within the last 3 weeks that have been committed to master, but are not on the main branch, which seems to be the new default branch. Would probably be a good idea to merge master into main 😉
Testing
Performed a manual test on a project that suffered from this error.
Docs
Just a bug fix. No docs.