Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Skypack SDK dependencies for Yarn 2 PnP #1797

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

msokk
Copy link
Contributor

@msokk msokk commented Dec 3, 2020

Changes

As Yarn 2 is strict with unlisted dependencies, it errors out with following for 3 packages: etag, mkdirp and find-up:

Error: skypack tried to access mkdirp, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Declared the missing utils.ts dependencies in skypack module package.json, used the same version as elsewhere.

Testing

Tested locally, it is hard to do it properly as Snowpack is running Yarn v1

Docs

Bug fix only

@vercel
Copy link

vercel bot commented Dec 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/geyh0jb75
✅ Preview: https://snowpack-git-fix-yarn-2-pnp.pikapkg.vercel.app

@msokk
Copy link
Contributor Author

msokk commented Dec 3, 2020

Currently the workaround is to manually define these dependencies in .yarnrrc.yml:

packageExtensions:
  skypack@*:
    dependencies:
      etag: '*'
      find-up: '*'
      mkdirp: '*'

@FredKSchott
Copy link
Owner

you're right, that's no good. Thank you!

@FredKSchott FredKSchott merged commit 7a2868f into FredKSchott:main Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants