Mark @web/dev-server import as external #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See dicussion FredKSchott#1732
|
@Pajn is attempting to deploy a commit to the Pika Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
force-pushed
the
main
branch
2 times, most recently
from
edbdee5 to
690285a
Compare
|
LGTM! Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Marks an internal @web/dev-server import as external that would otherwise cause an error in snowpacks install process. This is imported by
@web/test-runner-commandsSee discussion #1732 for further details
Testing
After adding this to my local snowpack config, my tests could run. After removing it an deleting the snowpack cache the tests failed again and finally after applying this patch they started to work again.
Docs
No docs, only a bug fix to avoid having to document an otherwise necessary config change.