Removed utf8 encoding #1676
Merged
Removed utf8 encoding #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The utf8 encoding breaks images from loading. Only noticed because I've built a small image editor and needed to load the image into canvas. Using this plugin broke some of my tests. Removing it fixes the issue and doesn't appear to have any negative effects. More details here modernweb-dev/web#980
|
@crisward is attempting to deploy a commit to the Pika Team on Vercel. A member of the Team first needs to authorize it. |
drwpow
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utf8 encoding breaks images from loading. Only noticed because I've built a small image editor and needed to load the image into canvas. Using this plugin broke some of my tests. Removing it fixes the issue and doesn't appear to have any negative effects.
More details here modernweb-dev/web#980
Changes
Removed default utf8 encoding, to allow images to be served correctly.
Testing
Not tested because I removed code, not added it. So I'd presume any tests written for this would break if I
broke anything 😉
Docs
bug fix only