Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esinstall: Update external packages support #1668

Merged
merged 1 commit into from
Nov 26, 2020
Merged

esinstall: Update external packages support #1668

merged 1 commit into from
Nov 26, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

  • update outdated externalEsm to new esmExternals
  • Add ability to pass esmExternals via option instead of process.env

Testing

  • Test added

Docs

  • N/A (behavior is not publicly useful)

@vercel
Copy link

vercel bot commented Nov 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/h99ag25gr
✅ Preview: https://snowpack-git-esinstall-external-esm.pikapkg.vercel.app

@FredKSchott FredKSchott merged commit 3fbf1a2 into main Nov 26, 2020
@FredKSchott FredKSchott deleted the esinstall-external-esm branch November 26, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwpow drwpow drwpow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @drwpow