Bumps esinstall's rollup version to fix lit-html error #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an error in esinstall with the lit-html library caused by the commonjs plugin + rollup version. In rollup v2.23 - v2.28.2 the transform hook would return undefined instead on the transformed library code. This error was fixed in the following pull: rollup/rollup@1ad8289#diff-58036290d63f45dcebfa80ddeeb5877187a613f7cdb28e9a5482324f632c14ad
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/34nkycd2r |
|
LGTM, but hopefully users are already getting this fix via the existing semver range |
|
Yeah, I hope so too. The problem can crop up if a user has a different version of rollup as a project dep, which is what was happening in our case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an error in esinstall with the lit-html library caused by the commonjs plugin + rollup version.
In rollup v2.23 - v2.28.2 the transform hook would return undefined instead on the transformed library code.
This error was fixed in the following pull: rollup/rollup@1ad8289#diff-58036290d63f45dcebfa80ddeeb5877187a613f7cdb28e9a5482324f632c14ad
Testing
All tests passing in local. No new tests added.
Docs
No new docs were added.