Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snowpack user types #1577

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Update snowpack user types #1577

merged 1 commit into from
Nov 12, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

  • Follow up to an issue brought up in Add a shape to the TS config files #1466 (comment)
  • Corrects some issues in our existing "SnowpackUserConfig", where "DeepPartial" wasn't cutting it: some user-facing config options were completely changed to become the easier-to-work-with SnowpackConfig options.

Testing

  • TS only change
  • partially tested by codebase with an added TODO that would increase confidence even further

Docs

  • N/A

@vercel
Copy link

vercel bot commented Nov 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/777zzhpdw
✅ Preview: https://snowpack-git-update-snowpack-user-types.pikapkg.vercel.app

@FredKSchott FredKSchott force-pushed the update-snowpack-user-types branch from cc59b4f to faf980d Compare November 11, 2020 06:41
@FredKSchott FredKSchott merged commit 1f50061 into master Nov 12, 2020
@FredKSchott FredKSchott deleted the update-snowpack-user-types branch November 12, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant