Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add init command, remove no command behavior #1526

Merged
merged 3 commits into from
Nov 6, 2020
Merged

add init command, remove no command behavior #1526

merged 3 commits into from
Nov 6, 2020

Conversation

FredKSchott
Copy link
Owner

@FredKSchott FredKSchott commented Nov 5, 2020 •
edited
Loading

Changes

  • Remove "no command' behavior (previously would run install.) This was legacy v1 behavior that was never documented as supported, so we now show the help command with an error exit code. You could definitely consider this a breaking change, but given that it was not documented and is now an error with obvious help output, I feel okay making this change.

Testing

  • No tests added

Docs

  • Added to docs output, @melissamcewen would love if you could incorporate this into the new Getting Started guide.

@vercel
Copy link

vercel bot commented Nov 5, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/l4r7958eu
✅ Preview: https://snowpack-git-init-command.pikapkg.vercel.app

FredKSchott
FredKSchott commented Nov 5, 2020
View reviewed changes
snowpack/assets/snowpack-init-file.js
@@ -0,0 +1,11 @@
// Snowpack Configuration File
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to any and all bikeshedding on this file format!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

drwpow
drwpow approved these changes Nov 5, 2020
View reviewed changes
Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@FredKSchott FredKSchott merged commit d20c655 into master Nov 6, 2020
@FredKSchott FredKSchott deleted the init-command branch November 6, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwpow drwpow drwpow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @drwpow