Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "@babel/preset-env" to Webpack plugin dependencies #1525

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Adding "@babel/preset-env" to Webpack plugin dependencies #1525

merged 2 commits into from
Nov 6, 2020

Conversation

melissamcewen
Copy link
Contributor

@melissamcewen melissamcewen commented Nov 5, 2020 •
edited
Loading

Changes

When using the Webpack plugin, I got this error when trying to build

Module build failed (from ../node_modules/babel-loader/lib/index.js):
Error: Cannot find module '@babel/preset-env' from '/Users/melissamcewen/Sites/my-first-snowpack/build'

Testing

TBA

Docs

Bug fix only

@vercel
Copy link

vercel bot commented Nov 5, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/qph21tiep
✅ Preview: https://snowpack-git-melissamcewen-patch-1.pikapkg.vercel.app

drwpow
drwpow approved these changes Nov 6, 2020
View reviewed changes
Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double approved

@melissamcewen melissamcewen marked this pull request as ready for review November 6, 2020 00:13
@melissamcewen melissamcewen mentioned this pull request Nov 6, 2020
Closed
@FredKSchott FredKSchott merged commit 14c10ec into master Nov 6, 2020
@FredKSchott FredKSchott deleted the melissamcewen-patch-1 branch November 6, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwpow drwpow drwpow approved these changes

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melissamcewen @FredKSchott @drwpow