Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the optimized etag check on index.html files #1524

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

FredKSchott
Copy link
Owner

Changes

Testing

  • N/A for dev etag tests.

Docs

  • N/A

@vercel
Copy link

vercel bot commented Nov 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/bwtwj9q5k
✅ Preview: https://snowpack-git-fix-bad-indexhtml-etags.pikapkg.vercel.app

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@FredKSchott FredKSchott merged commit 03c004d into master Nov 6, 2020
@FredKSchott FredKSchott deleted the fix-bad-indexhtml-etags branch November 6, 2020 04:00
@SashaOv
Copy link

SashaOv commented Jan 3, 2021

@FredKSchott I still observe this behavior in Snowpack 2.18.5 for a standalone HTML file. The code fo the fix seems to be in. Had to disable caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants