Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use the response handler #1519

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

stramel
Copy link
Contributor

@stramel stramel commented Nov 5, 2020

Changes

Utilizes the responseHandler variable which will properly check if config.expirements.app is set before calling the requestHandler.

Fixes the bug found in #1514

Testing

Manually tested

Docs

Bug fix only

@vercel
Copy link

vercel bot commented Nov 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/lgr382crg
✅ Preview: https://snowpack-git-ms-fix-request-handler.pikapkg.vercel.app

@stramel stramel marked this pull request as ready for review November 5, 2020 06:26
@dargue3
Copy link

dargue3 commented Nov 5, 2020

I surfaced this bug in discussion #1514 and I made these changes locally to my node_modules and can confirm that this is perfect for my auth middleware use case!

@FredKSchott
Copy link
Owner

Great, thanks @stramel!

@FredKSchott FredKSchott merged commit c0524a0 into FredKSchott:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants