reset etag with pathname only #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/cpj6n7rq8 |
drwpow
reviewed
Oct 27, 2020
snowpack/src/commands/dev.ts
Outdated
| const tag = etag(result.contents, {weak: true}); | ||
| knownETags.set(reqPath, tag); | ||
| if (reqPath.indexOf('?') >= 0) { | ||
| knownETags.set(reqPath.split('?', 2)[0], tag); |
There was a problem hiding this comment.
This seems fine to me, but @FredKSchott would know more if this affects anything for the etag.
There was a problem hiding this comment.
Ah yea, good catch. We have another way of doing this in the rest of the codebase: const reqPath = decodeURI(url.parse(reqUrl).pathname!); I'll update this PR to use that method.
peterhpchen
pushed a commit
to peterhpchen/snowpack
that referenced
this pull request
Oct 31, 2020
* reset etag with pathname only * Update dev.ts * Update dev.ts Co-authored-by: Fred K. Schott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to fix #1409
Changes
When running dev, if requesting url contains search part, then set etag to both origin url and pathname.
Testing
Don't know how to simply test response code for dev mode.
Docs
bug fix only