Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new optional param name of plugin-run-script #1414

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

moonrailgun
Copy link
Contributor

Its useful run two same cli.

In old case, i cannot make a distinction between those

Changes

plugin-run-script add new param which can modify display name of cmd by user

Testing

Add a testcase of specify name

Docs

Yep. update README.md of plugin-run-script

Its useful run two same cli.

In old case, i cannot make a distinction between those
@vercel
Copy link

vercel bot commented Oct 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/expjhqard
✅ Preview: https://snowpack-git-moonrailgun-add-runscript-name.pikapkg.vercel.app

@moonrailgun
Copy link
Contributor Author

BTW, I remove skip flag of this testcase. In comment its should be work

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Nice DX addition, thank you 🎉

@drwpow drwpow merged commit b0d7b09 into FredKSchott:master Oct 27, 2020
peterhpchen pushed a commit to peterhpchen/snowpack that referenced this pull request Oct 31, 2020
* Add new optional param name of plugin-run-script

Its useful run two same cli.

In old case, i cannot make a distinction between those

* add testcase of plugin-run-script name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants