Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @web/test-runner links in recipes #1382

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

mvasigh
Copy link
Contributor

@mvasigh mvasigh commented Oct 22, 2020

Changes

The "Recipes" section of the docs includes a pair of hyperlinks labeled @web/test-runner, but actually pointing to the @snowpack/app-scripts-react NPM page. This PR corrects those links.

Testing

No tests, docs change.

Docs

Updated.

@vercel
Copy link

vercel bot commented Oct 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/ox9cij4id
✅ Preview: https://snowpack-git-web-test-runner-links.pikapkg.vercel.app

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 😄 Thank you!

I’m not sure why the tests are failing; this is fine to merge (I’ll investigate after-the-fact.)

@drwpow drwpow merged commit 3d30c5a into FredKSchott:master Oct 27, 2020
peterhpchen pushed a commit to peterhpchen/snowpack that referenced this pull request Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants