add isHMR flag to loadUrl, and default off on isSSR #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/bxmkxq80u |
FredKSchott
force-pushed
the
loadurl-ishmr
branch
from
1c60825 to
2f60bf8
Compare
FredKSchott
force-pushed
the
loadurl-ishmr
branch
from
2f60bf8 to
c5dfa3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
isHMRoption toloadUrl()JS APIisHMRmode off whenisSSRis true, since HMR isn't meant to run on the serverrun()plugin hook option. Now that SSR mode is on/off per file, this flag no longer tracks. We had already addedisHmrEnabledto the build & transform functions.Testing
Docs