move one more warning behind verbose flag (this keyword is equivalent… #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to undefined at the top level)
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/5wotqumt3 |
|
LGTM! Will merge once tests pass |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Per discussion in #718 with @FredKSchott, this change silences the rollup
The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewrittenwarning, and move it behind the--verboseflag.Testing
I ran this local fork against my repo before and after the change, and noticed the warning being silenced.
I also ran
yarn testandyarn test:devDocs
The
10-reference.mdfile now mentions that this warning is silenced by default.