Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Minimal Tests for plugin-postcss #1357

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

thescripted
Copy link
Contributor

Changes

Added minimal snapshot tests for plugin-postcss. Please feel free to mention if I have missed anything, or should include additional tests.

Testing

Docs

@vercel
Copy link

vercel bot commented Oct 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/ftvhta3dh
✅ Preview: https://snowpack-git-postcss-test.pikapkg.vercel.app

@FredKSchott
Copy link
Owner

LGTM once you get tests passing!

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@drwpow drwpow merged commit 127ffd2 into FredKSchott:master Oct 27, 2020
peterhpchen pushed a commit to peterhpchen/snowpack that referenced this pull request Oct 31, 2020
* initial commit

* removed unnecessary mocks

* removed snapshots & mocked execa

* removed console logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants