Feature: Adding SRI hash(es) for HMR script resources #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the hard overwriting of console from jest and instead pipes it into a file that can be analyzed if something failes.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/a4p4yqk2c |
Merged
FredKSchott
reviewed
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR will add SRI hashes to HMR resources for building the pre-generated HTML file.
It will also resolves some conflicting issues with the logging for the
test-devresources.closes #1214
Testing
Build a test "snowpack-create-app" and run with with
snowpack devand got the following result:Also the smoke-dev test was adjusted accordingly
Docs
In my opinion this is a very small technical feature that doesn't need documenation as there's no configuration option for it anyway.
Assumptions / Disclaimers:
This will break support for IE in general, if this is supposed to work in IE then we need to remove the SRI hash for IE builds.
It was originally build under the intention to not be supported by IE.